fix: address external audit — criticals 1-5 + mediums · 90e6cfcc19 - cayce-ops

fix: address external audit — criticals 1-5 + mediums

Critical 1 (approval forgery): audit_log is now hash-chained
(prev_hash/entry_hash, verify_audit_chain); executor approve REQUIRES a
BIP-340 signature over sha256(cayce-ops:approve:<id>) when
CAYCE_OPS_OPERATOR_PUBKEY is set; deploy/roles.sql ships least-privilege
per-daemon DB roles.

Critical 2 (threading dead): sends create real OUTBOUND rows (own
Message-ID, In-Reply-To -> inbound); inbound message_id never overwritten;
maild compose adds the first-contact path; _match_proposal falls back to
inbound chains.

Critical 3 (duplicate sends): per-message transactions in send path —
SMTP failure on message N no longer resurrects 1..N-1; failures audited
(send_failed) and the row stays queued.

Critical 4 (classifier): negated approvals (cannot accept / not approved /
not accepting) classify REJECTION at 0.95 before the bare-keyword rule;
LLM prompt braces escaped (.format no longer KeyError into silent fallback).

Critical 5 (systemd): every daemon has a run subcommand
(maild run = poll+send, publisher run = publish-due, monitor run = build);
deploy README documents the separate daily publisher plan timer.

Mediums: approved_hash binds drafts/captions to the approved text (edited
text refuses to send/publish until re-approved); risk_score renamed
match_score (migration 0002) and auto-approve orders HIGHEST relevance
first; compose binds postgres to 127.0.0.1; IMAP marks \\Seen only after
commit (fetch returns (num, raw), mark post-commit); disabled channels are
terminal (ContentStatus.SKIPPED) and publish failures burn a bounded
attempt budget before abandonment; make hooks installs the pre-push gate.

tests: 12 new — 56 total, all green; ruff 0 findings; gitleaks clean.

This commit is contained in:

cayce

2026-10-19 23:06:29 +00:00

parent 2da5f3ff24

commit 90e6cfcc19

22 changed files with 1012 additions and 135 deletions

									
										.env.example
									
		+3
		
												View File
												
				@@ -21,6 +21,9 @@ CAYCE_OPS_AUTONOMOUS_KINDS=

				CAYCE_OPS_AUTONOMOUS_DAILY_CAP=0

				CAYCE_OPS_MAX_ATTEMPTS=2

				CAYCE_OPS_ENABLE_HTTP_ACTIONS=false

				# when set (64-char hex x-only pubkey), executor approve REQUIRES a BIP-340

				# signature over sha256("cayce-ops:approve:<id>") made by the operator key

				CAYCE_OPS_OPERATOR_PUBKEY=

				# --- mail (IMAP read / SMTP send-approved-drafts-only) ---

				CAYCE_OPS_IMAP_HOST=imap.example.org